Invalid TOTP

ganeshpanpat

TypeError Traceback (most recent call last)
<ipython-input-37-b86ba37da6be> in <module>
1 obj=SmartConnect(api_key=apikey)
----> 2 data = obj.generateSession(username,pwd,totp)
3 data

TypeError: generateSession() takes 3 positional arguments but 4 were given

getting this error

whemant

@ganeshpanpat I am also getting this error. @admin kindly assist.

punit

Code was updated to send totp, need to checkout new code or edit smartConnect.py file.. Really annoying release process.

tinvenc

@SaralaKannan

This link shows how to enable totp and use in the sdk
https://smartapi.angelbroking.com/topic/2377/guide-to-secure-your-smartapi-account-with-two-factor-authentication?_=1664622563730

er.anujkaushal

@tinvenc
this link is not working, what to do?

https://apiconnect.angelbroking.com/rest/auth/angelbroking/user/v1/loginByPassword

mihirshah2500

Even if there is any change around including TOTP in the Smartconnect generateSession, the SmartAPI library is not updated by Angel.

The older version was 1.2.9 and even if I reinstall the library now, it still is same. https://github.com/angel-one/smartapi-python

The error I am getting by adding TOTP in the generateSession is:
"TypeError: SmartConnect.generateSession() takes 3 positional arguments but 4 were given"

I have never seen a more irresponsible release plan for any user-facing product.

![0_1664626375677_Screenshot 2022-10-01 at 5.42.47 PM.png](Uploading 100%)

tinvenc

@mihirshah2500

I do agree, I was debugging from morning to understand why its not working and going through many links here

tinvenc

@er-anujkaushal

This link will be used by the SDK for login, You have to follow the numbered steps in the link an update the code, and pass the value for new parameter added

admin

Hi @mihirshah2500

Please follow below steps

Step 1: Checkout smart api python repo (https://github.com/angel-one/smartapi-python)
Step 2: Checkout the main branch if not already there
Step 3: Run python setup.py install

mihirshah2500

@admin I don't think this is the best way for users to update the library on their end.
Why can't Angel team update the library version, so that its an online sync that can be done without checking out the smart api repository?

admin

@mihirshah2500 @tinvenc @cpsingh @priya @rakeshnp @Ashok

Totp changes have been deployed in the latest python release 1.3.0
Please use the following command to upgrade to the latest python release
pip install smartapi-python --upgrade

jupyter

@ganeshpanpat were you able to solve this?

jupyter

@admin Still facing the same error. "TypeError: SmartConnect.generateSession() takes 3 positional arguments but 4 were given"

ganeshpanpat

@jupyter Yes.. its working now

jupyter

@ganeshpanpat I am still not sure where I am going wrong. I have updated the library with the latest version to 1.30. I am passing the TOTP parameter correctly. Can you suggest what can I be doing wrong?

punit

@jupyter Can you post the error or Message me ?

Balaji27

Dear Admin,

generateSession() takes 3 positional arguments but 4 were given

Please help,

only three arguments has been passed, but its throwing this error.

data = obj.generateSession("Your Client ID","Your Password","Your totp")
refreshToken= data['data']['refreshToken']

Reference: https://github.com/angel-one/smartapi-python

mihirshah2500

@admin Thank you, working now.

Requesting Angel team to follow quality practices for releases/updates, by:

Giving notice in advance on the changes
Updating Libraries and not just their internal systems (which was done here eventually after requesting), so that API users can also update on their end.

Balaji27

@Ashok generateSession() takes 3 positional arguments but 4 were given

Please help,

only three arguments has been passed, but its throwing this error.

data = obj.generateSession("Your Client ID","Your Password","Your totp")
refreshToken= data['data']['refreshToken']

Reference: https://github.com/angel-one/smartapi-python

webseos

PyOtp was not working and I was getting the following error :
Error : Object of type TOTP is not JSON serializable

But then I added last two lines and problem solved the last two lines given at the end of the following code- qrOtp is the code generated here : https://smartapi.angelbroking.com/enable-totp below the QR Code

My Code Below

from smartapi import SmartConnect #or from smartapi.smartConnect import SmartConnect
import config
import pyotp

------- Angel Account -----------------

client_code = "aaaaaa"
client_pass = "bbbbbb"

apiKey="yyyyyyy"
qrOtp = "xxxxxxxx"
totp = pyotp.TOTP(qrOtp)
totp = totp.now()

create object of call

smartapiObj =SmartConnect(apiKey)

login api call

data = smartapiObj.generateSession(client_code,client_pass,totp)
print(data)